Thread (2 messages) 2 messages, 2 authors, 2015-03-24

Re: [PATCH] staging: sm750fb: Fixed C99 comments warnings

flat view

From: Dan Carpenter <hidden>
Date: 2015-03-24 07:57:11
Also in: lkml

On Mon, Mar 23, 2015 at 09:51:54PM -0700, Ragavendra Nagraj wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 02f9326..1fb00a4 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -17,7 +17,7 @@ logical_chip_type_t getChipType(void)
 	char physicalRev;
 	logical_chip_type_t chip;
 
-	physicalID = devId750;//either 0x718 or 0x750
+	physicalID = devId750;/*either 0x718 or 0x750*/
This should be:

	physicalID = devId750; /* either 0x718 or 0x750 */
quoted hunk ↗ jump to hunk
@@ -501,7 +501,7 @@ unsigned int calcPllValue(unsigned int request_orig,pll_value_t *pll)
 		}
 	}
 
-	//printk("Finally:  pll->n[%lu],m[%lu],od[%lu],pod[%lu]\n",pll->N,pll->M,pll->OD,pll->POD);
+	/*printk("Finally:  pll->n[%lu],m[%lu],od[%lu],pod[%lu]\n",pll->N,pll->M,pll->OD,pll->POD);*/
Just delete this dead code.

Please redo.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help