Re: [PATCH 3/6] staging: sm750fb: Make internal functions static

From
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date
2015-03-11 09:30:11
Also in
lkml
Reply to
Lorenzo Stoakes, 2015-03-11
On Wed, Mar 11, 2015 at 01:28:42AM +0000, Lorenzo Stoakes wrote:
This patch declares externally unavailable functions static. This fixes the
following sparse warnings:-
<snip>
quoted hunk ↗ jump to hunk
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 6521c3b..4aa763b 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -92,7 +92,7 @@ void hw_set2dformat(struct lynx_accel * accel,int fmt)
 /* seems sm712 RectFill command is broken,so need use BitBlt to
  * replace it. */
 
-int hw712_fillrect(struct lynx_accel * accel,
+static int hw712_fillrect(struct lynx_accel * accel,
 				u32 base,u32 pitch,u32 Bpp,
 				u32 x,u32 y,u32 width,u32 height,
 				u32 color,u32 rop)
this is introducing a build warning, better remove this from your patch
and send a separate patch to remove the function as this function is
not used anywhere.

regards
sudip
-- 
2.3.2
Thread (18 messages) 18 messages, 3 authors, last reply 2015-03-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help