Re: [PATCH 6/6] staging: sm750fb: correct integer comparison
From: Dan Carpenter <hidden>
Date: 2015-03-11 07:58:11
Also in:
lkml
On Tue, Mar 10, 2015 at 10:46:57PM +0530, Sudip Mukherjee wrote:
quoted hunk ↗ jump to hunk
fixed the build warning about comparison of pointer and integer. end of string was being compared to NULL. Signed-off-by: Sudip Mukherjee <redacted> --- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 021b863..5532a28 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c@@ -1000,7 +1000,7 @@ static void sm750fb_setup(struct lynx_share * share,char * src) goto NO_PARAM; } - while((opt = strsep(&src,":")) != NULL && *opt != NULL){ + while((opt = strsep(&src,":")) != NULL && *opt != 0){
Use '\0' for the NUL char. regards, dan carpenter