Thread (7 messages) 7 messages, 3 authors, 2015-03-10

Re: [PATCH] staging: sm750fb: Fix sparse warning

From: Lorenzo Stoakes <hidden>
Date: 2015-03-10 08:47:52
Also in: lkml

On 10 March 2015 at 07:00, Dan Carpenter [off-list ref] wrote:
No need for the volatile.
Will remove.
Really mmio750 should be a "void __iomem *"
it is declared as "unsigned char __iomem *" but it's not a char pointer
that's only to make the pointer math work.  It would work just as well
as a void and we could remove some ugly casting.
I'm thinking the change to "void __iomem *" from "unsigned char
__iomem *" ought to be a separate patch in order to keep this cleanly
focused on solving the sparse warning? Am more than happy to do this
and make the appropriate changes to the macros in ddk750_help.h.

-- 
Lorenzo Stoakes
https:/ljs.io
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help