Re: [PATCH 3/3] staging: sm7xxfb: change return of sm7xx_vga_setup
flat view
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2015-03-09 13:30:47
Also in:
lkml
On Mon, Mar 09, 2015 at 04:13:43PM +0300, Dan Carpenter wrote:
On Sun, Mar 08, 2015 at 11:10:11PM +0530, Sudip Mukherjee wrote:quoted
change return type of sm7xx_vga_setup() to void as we are not using the return type anywhere. if this function fails we fall back to the default configuration. Signed-off-by: Sudip Mukherjee <redacted>Reviewed-by: Dan Carpenter <redacted> This patch is fine but if you wanted you could send a follow on which set it to SCREEN_X_RES, SCREEN_Y_RES, SCREEN_BPP if there were no options. Then remove the "if (smtc_scr_info.lfb_width != 0) " condition in smtcfb_pci_probe().
yes, i could have. But actually I am thinking to totally remove this function and use more conventional fb_get_mode() in its places. But if i do so then the boot parameters will change. Currently it is like vga=sm712fb:0x301 but if i change it to use fb_get_mode() then the boot parameters will change to vga=sm712fb:640x480@60-8 , and that is why I am hesitating. But it will be more conventional to what all framebuffer drivers follows. regards sudip
regards, dan carpenter