Re: Build warning for unused function in the file,sm7xxfb.c

On Thu, Feb 26, 2015 at 08:48:00AM -0800, Greg KH wrote:

On Thu, Feb 26, 2015 at 10:44:00AM +0530, Sudip Mukherjee wrote:

quoted

On Wed, Feb 25, 2015 at 08:33:41PM -0800, Greg KH wrote:

quoted

On Thu, Feb 26, 2015 at 09:57:31AM +0530, Sudip Mukherjee wrote:

I suggest updating your personal blacklist as well, it makes things
easier.

yes, better. and i was just seeing some of his patches, mostly all are removing of FIXME comments.

but i got confused with bab5bb398273bb37547a185f7b344b37c700d0b9
he has removed a call to function kvm_make_request() and introduced a new function kvm_set_pending_timer() which is just calling kvm_make_request(). and the commit message just says "Adds a function kvm_vcpu_set_pending_timer instead of calling kvm_make_request in lapic.c." , i am just unable to understand why this change?

I don't understand the change either, I suggest asking the kvmm
developer who accepted it.

Hi Paolo,
We have a small confusion about commit bab5bb398273bb37547a185f7b344b37c700d0b9. It looks like the patch removed a call to function kvm_make_request() and introduced a new function kvm_set_pending_timer() which is just calling kvm_make_request() again. and the commit message just says "Adds a function kvm_vcpu_set_pending_timer instead of calling kvm_make_request in lapic.c.".

regards
sudip

thanks,

greg k-h