[PATCH] staging/sm7xxfb: Make 'struct vgamode' static

Subsystems: staging subsystem, the rest

STALE4194d

3 messages, 3 authors, 2015-03-07 · open the first message on its own page

[PATCH] staging/sm7xxfb: Make 'struct vgamode' static

From: Peter Senna Tschudin <peter.senna@gmail.com>
Date: 2015-02-23 11:16:40

sparse was complaining that symbol 'vgamode' was not declared.

Declaring vgamode as static.

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
Tested by compilation only

 drivers/staging/sm7xxfb/sm7xx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h
index 7cc1896..c5d6253 100644
--- a/drivers/staging/sm7xxfb/sm7xx.h
+++ b/drivers/staging/sm7xxfb/sm7xx.h
@@ -119,7 +119,7 @@ struct ModeInit {
 /**********************************************************************
 			 SM712 Mode table.
  **********************************************************************/
-struct ModeInit vgamode[] = {
+static struct ModeInit vgamode[] = {
 	{
 	 /*  mode#0: 640 x 480  16Bpp  60Hz */
 	 640, 480, 16, 60,
-- 
2.1.0

Re: [PATCH] staging/sm7xxfb: Make 'struct vgamode' static

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2015-02-24 05:46:39

On Mon, Feb 23, 2015 at 12:16:16PM +0100, Peter Senna Tschudin wrote:
sparse was complaining that symbol 'vgamode' was not declared.

Declaring vgamode as static.
a similar patch has already been sent to Greg, which is not yet applied.

regards
sudip
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
-- 
2.1.0

Re: [PATCH] staging/sm7xxfb: Make 'struct vgamode' static

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2015-03-07 11:00:46

On Mon, Feb 23, 2015 at 12:16:16PM +0100, Peter Senna Tschudin wrote:
sparse was complaining that symbol 'vgamode' was not declared.

Declaring vgamode as static.

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
Tested by compilation only

 drivers/staging/sm7xxfb/sm7xx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
As was mentioned, someone sent this before you did, sorry.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help