[PATCH] fbdev: sm501fb: use memset_io

Subsystems: framebuffer layer, the rest

STALE4191d

2 messages, 2 authors, 2015-02-20 · open the first message on its own page

[PATCH] fbdev: sm501fb: use memset_io

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2015-02-10 12:38:04

we should really be using memset_io() instead of using memset() as
this is actually io space mapped into our memory.

Signed-off-by: Sudip Mukherjee <redacted>
---
it has only been build tested. I only have the hardware of sm712 and sm750.

 drivers/video/fbdev/sm501fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
index e8d4121..d0a4e2f 100644
--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -1606,7 +1606,7 @@ static int sm501fb_start(struct sm501fb_info *info,
 	info->fbmem_len = resource_size(res);
 
 	/* clear framebuffer memory - avoids garbage data on unused fb */
-	memset(info->fbmem, 0, info->fbmem_len);
+	memset_io(info->fbmem, 0, info->fbmem_len);
 
 	/* clear palette ram - undefined at power on */
 	for (k = 0; k < (256 * 3); k++)
-- 
1.8.1.2

Re: [PATCH] fbdev: sm501fb: use memset_io

From: Tomi Valkeinen <hidden>
Date: 2015-02-20 12:10:16

On 10/02/15 14:37, Sudip Mukherjee wrote:
quoted hunk
we should really be using memset_io() instead of using memset() as
this is actually io space mapped into our memory.

Signed-off-by: Sudip Mukherjee <redacted>
---
it has only been build tested. I only have the hardware of sm712 and sm750.

 drivers/video/fbdev/sm501fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
index e8d4121..d0a4e2f 100644
--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -1606,7 +1606,7 @@ static int sm501fb_start(struct sm501fb_info *info,
 	info->fbmem_len = resource_size(res);
 
 	/* clear framebuffer memory - avoids garbage data on unused fb */
-	memset(info->fbmem, 0, info->fbmem_len);
+	memset_io(info->fbmem, 0, info->fbmem_len);
 
 	/* clear palette ram - undefined at power on */
 	for (k = 0; k < (256 * 3); k++)
Thanks, queued for 3.21.

 Tomi

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help