Hi All,
Please review this patch.
this patch is aimed to solve some indentation issue. It has also solved
three trivial error in efifb.c file.
And I have also changed printk with pr_err, pr_info ... at respective places.
From c49139fac1d15fe2da80d06e2a79eb8be7c079a7 Mon Sep 17 00:00:00 2001
From: Parmeshwr Prasad <redacted>
Date: Mon, 9 Feb 2015 07:33:59 -0500
Subject: [PATCH] Trival patch: improved indentation, and removed some ERROR
from code
Signed-off-by: Parmeshwr Prasad <redacted>
---
drivers/video/fbdev/efifb.c | 158 +++++++++++++++++++++++---------------------
1 file changed, 84 insertions(+), 74 deletions(-)
@@ -89,25 +88,35 @@ static int efifb_setup(char *options) if (options && *options) { while ((this_opt = strsep(&options, ",")) != NULL) {- if (!*this_opt) continue;+ if (!*this_opt)+ continue; for (i = 0; i < M_UNKNOWN; i++) { if (efifb_dmi_list[i].base != 0 &&- !strcmp(this_opt,
@@ -142,10 +151,10 @@ static int efifb_probe(struct platform_device *dev) if (!screen_info.pages) screen_info.pages = 1; if (!screen_info.lfb_base) {- printk(KERN_DEBUG "efifb: invalid framebuffer address\n");+ pr_err("efifb: invalid framebuffer address\n"); return -ENODEV; }- printk(KERN_INFO "efifb: probing for efifb\n");+ pr_info("efifb: probing for efifb\n"); /* just assume they're all unset if any are */ if (!screen_info.blue_size) {
@@ -181,7 +190,7 @@ static int efifb_probe(struct platform_device *dev) * use for efifb. With modern cards it is no * option to simply use size_total as that * wastes plenty of kernel address space. */- size_remap = size_vmode * 2;+ size_remap = size_vmode * 2; if (size_remap > size_total) size_remap = size_total; if (size_remap % PAGE_SIZE)
@@ -193,14 +202,14 @@ static int efifb_probe(struct platform_device *dev) } else { /* We cannot make this fatal. Sometimes this comes from magic spaces our resource handlers simply don't know about */- printk(KERN_WARNING+ pr_warn( "efifb: cannot reserve video memory at 0x%lx\n",- efifb_fix.smem_start);+ efifb_fix.smem_start); } info = framebuffer_alloc(sizeof(u32) * 16, &dev->dev); if (!info) {- printk(KERN_ERR "efifb: cannot allocate framebuffer\n");+ pr_err("efifb: cannot allocate framebuffer\n"); err = -ENOMEM; goto err_release_mem; }
Hi,
Thanks for the patch.
On Mon, Feb 9, 2015 at 12:55 PM, Parmeshwr Prasad
[off-list ref] wrote:
Hi All,
Please review this patch.
this patch is aimed to solve some indentation issue. It has also solved
three trivial error in efifb.c file.
And I have also changed printk with pr_err, pr_info ... at respective places.
From c49139fac1d15fe2da80d06e2a79eb8be7c079a7 Mon Sep 17 00:00:00 2001
From: Parmeshwr Prasad <redacted>
Date: Mon, 9 Feb 2015 07:33:59 -0500
Subject: [PATCH] Trival patch: improved indentation, and removed some ERROR
from code
Signed-off-by: Parmeshwr Prasad <redacted>
---
1: did you use git to send this patch ?
2: did you checkpatch it (I see some issues)?
3: break this patch into 2 one fixing the 3 issues and other fixing
the indentation.
4: have proper commit message.
Cheers,
--Prabhakar Lad
I have created two patch now.
0001-Trival-patch-improved-indentation-in-efifb.c-file.patch:
This patch solves indentation issue in efifb.c file.
This don't has any code change.
I checked with checkpatch.pl it has some warning to remove some old functions in
efifb.c. my changes are not to address that. That changes I can try in my next
patch.
0002-Trivial-patch-In-this-patch-printk-is-replaced-by-pr.patch:
This is addressing following changes:
1- It has removed "quoted string split across lines" warning.
2- There was static initialization of request_mem_succeeded, which is removed.
3- Assignment in if condition, this is fixed.
This one I have checked with checkpatch.pl it don't has any warning or comment.
I am sending these patches with mutt.
From 8ce800b5f5a048109014994bcfc4fae2ef9cc271 Mon Sep 17 00:00:00 2001
From: Parmeshwr Prasad <redacted>
Date: Tue, 10 Feb 2015 00:33:30 -0500
Subject: [PATCH] Trival patch: improved indentation in efifb.c file
Signed-off-by: Parmeshwr Prasad <redacted>
---
drivers/video/fbdev/efifb.c | 128 +++++++++++++++++++++++---------------------
1 file changed, 68 insertions(+), 60 deletions(-)
@@ -89,25 +88,35 @@ static int efifb_setup(char *options) if (options && *options) { while ((this_opt = strsep(&options, ",")) != NULL) {- if (!*this_opt) continue;+ if (!*this_opt)+ continue; for (i = 0; i < M_UNKNOWN; i++) { if (efifb_dmi_list[i].base != 0 &&- !strcmp(this_opt,
@@ -181,7 +190,7 @@ static int efifb_probe(struct platform_device *dev) * use for efifb. With modern cards it is no * option to simply use size_total as that * wastes plenty of kernel address space. */- size_remap = size_vmode * 2;+ size_remap = size_vmode * 2; if (size_remap > size_total) size_remap = size_total; if (size_remap % PAGE_SIZE)
@@ -195,7 +204,7 @@ static int efifb_probe(struct platform_device *dev) spaces our resource handlers simply don't know about */ printk(KERN_WARNING "efifb: cannot reserve video memory at 0x%lx\n",- efifb_fix.smem_start);+ efifb_fix.smem_start); } info = framebuffer_alloc(sizeof(u32) * 16, &dev->dev);
1.9.3
-Parmeshwr
On Mon, Feb 09, 2015 at 08:24:50AM -0600, Lad, Prabhakar wrote:
Hi,
Thanks for the patch.
On Mon, Feb 9, 2015 at 12:55 PM, Parmeshwr Prasad
[off-list ref] wrote:
quoted
Hi All,
Please review this patch.
this patch is aimed to solve some indentation issue. It has also solved
three trivial error in efifb.c file.
And I have also changed printk with pr_err, pr_info ... at respective places.
From c49139fac1d15fe2da80d06e2a79eb8be7c079a7 Mon Sep 17 00:00:00 2001
From: Parmeshwr Prasad <redacted>
Date: Mon, 9 Feb 2015 07:33:59 -0500
Subject: [PATCH] Trival patch: improved indentation, and removed some ERROR
from code
Signed-off-by: Parmeshwr Prasad <redacted>
---
1: did you use git to send this patch ?
2: did you checkpatch it (I see some issues)?
3: break this patch into 2 one fixing the 3 issues and other fixing
the indentation.
4: have proper commit message.
Cheers,
--Prabhakar Lad
On Tue, Feb 10, 2015 at 02:06:24AM -0600, Prasad, Parmeshwr wrote:
This is secong patch.
This is addressing following changes:
1- It has removed "quoted string split across lines" warning.
2- There was static initialization of request_mem_succeeded, which is removed.
3- Assignment in if condition, this is fixed.
From bf6328196341ea36ec79fba71b9b5c2c36d61043 Mon Sep 17 00:00:00 2001
From: Parmeshwr Prasad <redacted>
Date: Tue, 10 Feb 2015 02:49:26 -0500
Subject: [PATCH 2/2] Trivial patch: In this patch printk is replaced by pr_*
macros and static initialization of request_mem_succeeded is removed and
assignment in if condition is removed
Signed-off-by: Parmeshwr Prasad <redacted>
---
drivers/video/fbdev/efifb.c | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
@@ -151,10 +153,10 @@ static int efifb_probe(struct platform_device *dev)if(!screen_info.pages)screen_info.pages=1;if(!screen_info.lfb_base){-printk(KERN_DEBUG"efifb: invalid framebuffer address\n");+pr_err("efifb: invalid framebuffer address\n");return-ENODEV;}-printk(KERN_INFO"efifb: probing for efifb\n");+pr_info("efifb: probing for efifb\n");/* just assume they're all unset if any are */if(!screen_info.blue_size){
@@ -202,14 +204,14 @@ static int efifb_probe(struct platform_device *dev)}else{/* We cannot make this fatal. Sometimes this comes from magicspacesourresourcehandlerssimplydon'tknowabout*/-printk(KERN_WARNING+pr_warn("efifb: cannot reserve video memory at 0x%lx\n",efifb_fix.smem_start);}info=framebuffer_alloc(sizeof(u32)*16,&dev->dev);if(!info){-printk(KERN_ERR"efifb: cannot allocate framebuffer\n");+pr_err("efifb: cannot allocate framebuffer\n");err=-ENOMEM;gotoerr_release_mem;}
@@ -228,25 +230,23 @@ static int efifb_probe(struct platform_device *dev)info->screen_baseioremap_wc(efifb_fix.smem_start,efifb_fix.smem_len);if(!info->screen_base){-printk(KERN_ERR"efifb: abort, cannot ioremap video memory "-"0x%x @ 0x%lx\n",-efifb_fix.smem_len,efifb_fix.smem_start);+pr_err("efifb: abort, cannot ioremap video memory 0x%x @ 0x%lx+\n", efifb_fix.smem_len, efifb_fix.smem_start);err=-EIO;gotoerr_release_fb;}-printk(KERN_INFO"efifb: framebuffer at 0x%lx, mapped to 0x%p, "-"using %dk, total %dk\n",-efifb_fix.smem_start,info->screen_base,+pr_info("efifb: framebuffer at 0x%lx, mapped to 0x%p,using %dk,
1.9.3
This don't has any checkpatch.pl comment/warning.
-Parmeshwr
quoted hunk
I have created two patch now.
0001-Trival-patch-improved-indentation-in-efifb.c-file.patch:
This patch solves indentation issue in efifb.c file.
This don't has any code change.
I checked with checkpatch.pl it has some warning to remove some old functions in
efifb.c. my changes are not to address that. That changes I can try in my next
patch.
0002-Trivial-patch-In-this-patch-printk-is-replaced-by-pr.patch:
This is addressing following changes:
1- It has removed "quoted string split across lines" warning.
2- There was static initialization of request_mem_succeeded, which is removed.
3- Assignment in if condition, this is fixed.
This one I have checked with checkpatch.pl it don't has any warning or comment.
I am sending these patches with mutt.
From 8ce800b5f5a048109014994bcfc4fae2ef9cc271 Mon Sep 17 00:00:00 2001
From: Parmeshwr Prasad <redacted>
Date: Tue, 10 Feb 2015 00:33:30 -0500
Subject: [PATCH] Trival patch: improved indentation in efifb.c file
Signed-off-by: Parmeshwr Prasad <redacted>
---
drivers/video/fbdev/efifb.c | 128 +++++++++++++++++++++++---------------------
1 file changed, 68 insertions(+), 60 deletions(-)
@@ -89,25 +88,35 @@ static int efifb_setup(char *options) if (options && *options) { while ((this_opt = strsep(&options, ",")) != NULL) {- if (!*this_opt) continue;+ if (!*this_opt)+ continue; for (i = 0; i < M_UNKNOWN; i++) { if (efifb_dmi_list[i].base != 0 &&- !strcmp(this_opt,
@@ -181,7 +190,7 @@ static int efifb_probe(struct platform_device *dev) * use for efifb. With modern cards it is no * option to simply use size_total as that * wastes plenty of kernel address space. */- size_remap = size_vmode * 2;+ size_remap = size_vmode * 2; if (size_remap > size_total) size_remap = size_total; if (size_remap % PAGE_SIZE)
@@ -195,7 +204,7 @@ static int efifb_probe(struct platform_device *dev) spaces our resource handlers simply don't know about */ printk(KERN_WARNING "efifb: cannot reserve video memory at 0x%lx\n",- efifb_fix.smem_start);+ efifb_fix.smem_start); } info = framebuffer_alloc(sizeof(u32) * 16, &dev->dev);
1.9.3
-Parmeshwr
On Mon, Feb 09, 2015 at 08:24:50AM -0600, Lad, Prabhakar wrote:
quoted
Hi,
Thanks for the patch.
On Mon, Feb 9, 2015 at 12:55 PM, Parmeshwr Prasad
[off-list ref] wrote:
quoted
Hi All,
Please review this patch.
this patch is aimed to solve some indentation issue. It has also solved
three trivial error in efifb.c file.
And I have also changed printk with pr_err, pr_info ... at respective places.
From c49139fac1d15fe2da80d06e2a79eb8be7c079a7 Mon Sep 17 00:00:00 2001
From: Parmeshwr Prasad <redacted>
Date: Mon, 9 Feb 2015 07:33:59 -0500
Subject: [PATCH] Trival patch: improved indentation, and removed some ERROR
from code
Signed-off-by: Parmeshwr Prasad <redacted>
---
1: did you use git to send this patch ?
2: did you checkpatch it (I see some issues)?
3: break this patch into 2 one fixing the 3 issues and other fixing
the indentation.
4: have proper commit message.
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html