[PATCH] staging: sm7xxfb: make smtc_scr_info static

Subsystems: staging subsystem, the rest

STALE4208d

4 messages, 3 authors, 2015-02-03 · open the first message on its own page

[PATCH] staging: sm7xxfb: make smtc_scr_info static

From: Max Perepelitsyn <hidden>
Date: 2015-02-03 08:44:55

This symbol is never used anywhere else besides sm7xxfb.c

Signed-off-by: Max Perepelitsyn <redacted>
---
 drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 2ae9fd0..72036c2 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
 	{"0x31B", 1280, 1024, 24},
 };
 
-struct screen_info smtc_scr_info;
+static struct screen_info smtc_scr_info;
 
 /* process command line options, get vga parameter */
 static int __init sm7xx_vga_setup(char *options)
-- 
2.2.2

Re: [PATCH] staging: sm7xxfb: make smtc_scr_info static

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2015-02-03 14:04:21

On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
This symbol is never used anywhere else besides sm7xxfb.c
Hi Greg,
do i need to do anything about this patch? maybe a tested-by or reviewed-by?

regards
sudip
quoted hunk
Signed-off-by: Max Perepelitsyn <redacted>
---
 drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 2ae9fd0..72036c2 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
 	{"0x31B", 1280, 1024, 24},
 };
 
-struct screen_info smtc_scr_info;
+static struct screen_info smtc_scr_info;
 
 /* process command line options, get vga parameter */
 static int __init sm7xx_vga_setup(char *options)
-- 
2.2.2

Re: [PATCH] staging: sm7xxfb: make smtc_scr_info static

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2015-02-03 15:38:55

On Tue, Feb 03, 2015 at 07:34:01PM +0530, Sudip Mukherjee wrote:
On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
quoted
This symbol is never used anywhere else besides sm7xxfb.c
Hi Greg,
do i need to do anything about this patch? maybe a tested-by or reviewed-by?
If you test or review it, yes, please add such a line to an email and
reply to the patch with it.

thanks,

greg k-h

Re: [PATCH] staging: sm7xxfb: make smtc_scr_info static

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2015-02-03 17:32:42

On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
This symbol is never used anywhere else besides sm7xxfb.c

Signed-off-by: Max Perepelitsyn <redacted>
Tested-by: Sudip Mukherjee <redacted>
quoted hunk
---
 drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 2ae9fd0..72036c2 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
 	{"0x31B", 1280, 1024, 24},
 };
 
-struct screen_info smtc_scr_info;
+static struct screen_info smtc_scr_info;
 
 /* process command line options, get vga parameter */
 static int __init sm7xx_vga_setup(char *options)
-- 
2.2.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help