Re: [PATCH v2] video: fbdev: fix sys_copyarea

Tomi Valkeinen [off-list ref] writes:

On 22/01/15 03:19, Mans Rullgard wrote:

quoted

The sys_copyarea() function performs the same operation as
cfb_copyarea() but using normal memory access instead of I/O
accessors.  Since the introduction of sys_copyarea(), there
have been two fixes to cfb_copyarea():

- 00a9d699 ("framebuffer: fix cfb_copyarea")
- 5b789da8 ("framebuffer: fix screen corruption when copying")

This patch incorporates the fixes into sys_copyarea() as well.

Signed-off-by: Mans Rullgard <redacted>
---
Changed in v2:
 - Fixed wrong first/last calculation in bitcpy_rev()
---
 drivers/video/fbdev/core/syscopyarea.c | 137 ++++++++++++++++-----------------
 1 file changed, 65 insertions(+), 72 deletions(-)

Thanks, queued for 3.20.

This makes me wonder, though, if the sys and cfb versions could be
somehow combined...

I would have done it by #including a common template with different
macro definitions for the memory access operations.

-- 
Måns Rullgård
mans@mansr.com