Re: [PATCH] video: fbdev: omap2: dss: rfbi.c: Remove some unused functions

From
Tomi Valkeinen <hidden>
Date
2015-01-13 11:00:54
Also in
linux-omap, lkml
Reply to
Rickard Strandqvist, 2014-12-21
On 21/12/14 19:02, Rickard Strandqvist wrote:
Removes some functions that are not used anywhere:
rfbi_init_display() rfbi_display_disable() rfbi_display_enable()
rfbi_set_interface_timings() rfbi_set_data_lines() rfbi_set_pixel_size()
rfbi_set_size() rfbi_update() rfbi_configure() rfbi_enable_te()
rfbi_setup_te() rfbi_write_pixels() rfbi_write_data() rfbi_read_data()
rfbi_write_command() rfbi_bus_unlock() rfbi_bus_lock()

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/omap2/dss/rfbi.c |  297 ----------------------------------
 1 file changed, 297 deletions(-)
It's true those functions are not used anywhere, but RFBI is currently
marked as BROKEN so it cannot be compiled and the functions do not do
any harm. I'd rather keep them, as they give an insight how the rfbi
should work if and when someone will fix the driver.

 Tomi

Attachments

Thread (2 messages) 2 messages, 2 authors, last reply 2015-01-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help