Re: [PATCH] x86, ia64: Do not lose track of the EFI default VGA device
From: Bruno Prémont <bonbons@linux-vserver.org>
Date: 2014-11-14 14:52:40
Also in:
lkml
On Fri, 14 Nov 2014 13:53:30 +0100 Henrik Rydberg wrote:
Since commit 20cde694027e ("x86, ia64: Move EFI_FB
vga_default_device() initialization to pci_vga_fixup()") in the 3.17
merge window, the EFI framebuffer depends on the VGA arbitration
layer. However, the configuration does not reflect this, which leads
to a hard-to-find bug when FB_EFI is configured without VGA_ARB. Add a
select clause to remedy this.Could you be more verbose in why it depends on/needs VGA_ARB? With EFI starting to show up on ARM this is not necessarily true (no PCI -> no VGA_ARB arbitration). So it would need to at least be select VGA_ARB if (PCI && !S390) in order to not have broken kernel configuration (in more or less exotic cases) while depends on VGA_ARB would be the only correct option if the rule 'select only allowed for leafs' is enforced. Bruno
quoted hunk ↗ jump to hunk
Cc: Bruno Prémont <bonbons@linux-vserver.org> Signed-off-by: Henrik Rydberg <redacted> --- Hi Peter, I stumbled upon this bug from the 3.17 merge window when updating to Linus's 3.18 git head yesterday. The patch has been tested on two different EFI machines; one that needs the patch and one that does not. Thanks, Henrik drivers/video/fbdev/Kconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index c7bf606..81b21bc 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig@@ -761,6 +761,7 @@ config FB_EFI select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT + select VGA_ARB help This is the EFI frame buffer device driver. If the firmware on your platform is EFI 1.10 or UEFI 2.0, select Y to add support for