Re: [PATCH] video/fbdev: Always built-in video= cmdline parsing
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2014-08-06 10:27:32
Also in:
dri-devel, intel-gfx
Possibly related (same subject, not in this thread)
- 2014-08-06 · [PATCH] video/fbdev: Always built-in video= cmdline parsing · Daniel Vetter <hidden>
On Wed, Aug 6, 2014 at 11:43 AM, Daniel Vetter [off-list ref] wrote:
In drm/i915 we want to get at the video= cmdline modes even when we don't have fbdev support enabled, so that users can always override the kernel's initial mode selection. But that gives us a direct depency upon the parsing code in the fbdev subsystem. Since it's so little code just extract these 2 functions and always build them in.
How much is "so little"? Think memory-constrained systems. You can still build it depending on CONFIG_FB or CONFIG_DRM_I915.
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/fbdev/core/Makefile b/drivers/video/fbdev/core/Makefile index fa306538dac2..891c1f890e03 100644 --- a/drivers/video/fbdev/core/Makefile +++ b/drivers/video/fbdev/core/Makefile@@ -1,4 +1,4 @@ -obj-y += fb_notify.o
Oh, this is already unconditional. Who are its users?
quoted hunk ↗ jump to hunk
+obj-y += fb_notify.o fb_cmdline.o obj-$(CONFIG_FB) += fb.o fb-y := fbmem.o fbmon.o fbcmap.o fbsysfs.o \ modedb.o fbcvt.odiff --git a/drivers/video/fbdev/core/fb_cmdline.c b/drivers/video/fbdev/core/fb_cmdline.c new file mode 100644 index 000000000000..91503a43213e --- /dev/null +++ b/drivers/video/fbdev/core/fb_cmdline.c@@ -0,0 +1,103 @@ +/* + * linux/drivers/video/fb_cmdline.c + * + * Copyright (C) 2014 Intel Corp + * + * This file is subject to the terms and conditions of the GNU General Public + * License. See the file COPYING in the main directory of this archive + * for more details. + * + * Authors: + * Vetter <danie.vetter@ffwll.ch> + */
The above chunk doesn't sound appropriate for extracting existing code...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds