Re: [PATCH 6/7] video: fbdev: sis: delete double assignment
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2014-08-24 18:21:50
Also in:
kernel-janitors, lkml
On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall [off-list ref] wrote:
--- The patches in this series do not depend on each other. This changes the semantics of the code and is not tested.
Hence I think you should change the subject of the patch, so it's obvious some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment".
quoted hunk ↗ jump to hunk
drivers/video/fbdev/sis/init301.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c index a89e3ca..295e0de 100644 --- a/drivers/video/fbdev/sis/init301.c +++ b/drivers/video/fbdev/sis/init301.c@@ -1714,7 +1714,7 @@ SiS_GetLCDResInfo(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned sh SiS_Pr->PanelVCLKIdx315 = VCLK81_315; /* ? */ } else { SiS_Pr->PanelHT = 1688; SiS_Pr->PanelVT = 802; - SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRS = 112; + SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRE = 112;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds