Re: [PATCH v2] video: ARM CLCD: Fix calculation of bits-per-pixel

From
Pawel Moll <hidden>
Date
2014-08-20 13:03:09
Also in
linux-arm-kernel, lkml
Reply to
Jon Medhurst (Tixy), 2014-08-20
On Wed, 2014-08-20 at 13:41 +0100, Jon Medhurst (Tixy) wrote:
If the device-tree specifies a max-memory-bandwidth property then the
CLCD driver uses that to calculate the bits-per-pixel supported,
however, this calculation is faulty for two reasons.

1. It doesn't ensure that the result is a sane value, i.e. a power of 2
   and <= 32 as the rest of the code assumes.

2. It uses the displayed resolution and calculates the average bandwidth
   across the whole frame. It should instead calculate the peak
   bandwidth based on the pixel clock.

This patch fixes both the above.

Signed-off-by: Jon Medhurst <redacted>
Acked-by: Pawel Moll <redacted>
Thread (3 messages) 3 messages, 3 authors, last reply 2014-08-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help