[PATCH] video: amba-clcd: Select FB_MODE_HELPERS

Subsystems: framebuffer layer, the rest

STALE4381d

4 messages, 3 authors, 2014-08-04 · open the first message on its own page

[PATCH] video: amba-clcd: Select FB_MODE_HELPERS

From: Mark Brown <broonie@kernel.org>
Date: 2014-08-01 15:53:50

From: Mark Brown <redacted>

The AMBA CLCD driver uses fb_videomode_from_videomode() so it needs to
select DB_MODE_HELPERS as well as VIDEOMODE_HELPERS.

Signed-off-by: Mark Brown <redacted>
---
 drivers/video/fbdev/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 37d473f..e222048 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -280,6 +280,7 @@ config FB_ARMCLCD
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
+	select FB_MODE_HELPERS
 	select VIDEOMODE_HELPERS if OF
 	help
 	  This framebuffer device driver is for the ARM PrimeCell PL110
-- 
2.0.0

Re: [PATCH] video: amba-clcd: Select FB_MODE_HELPERS

From: Russell King - ARM Linux <hidden>
Date: 2014-08-01 18:27:03

On Fri, Aug 01, 2014 at 04:53:50PM +0100, Mark Brown wrote:
From: Mark Brown <redacted>

The AMBA CLCD driver uses fb_videomode_from_videomode() so it needs to
select DB_MODE_HELPERS as well as VIDEOMODE_HELPERS.
It doesn't, not as I designed it at least.  It depends what other people
have done to my driver...

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

Re: [PATCH] video: amba-clcd: Select FB_MODE_HELPERS

From: Mark Brown <broonie@kernel.org>
Date: 2014-08-01 18:48:05

On Fri, Aug 01, 2014 at 07:27:03PM +0100, Russell King - ARM Linux wrote:
On Fri, Aug 01, 2014 at 04:53:50PM +0100, Mark Brown wrote:
quoted
The AMBA CLCD driver uses fb_videomode_from_videomode() so it needs to
select DB_MODE_HELPERS as well as VIDEOMODE_HELPERS.
It doesn't, not as I designed it at least.  It depends what other people
have done to my driver...
Ah, sorry - I didn't notice that this is as a result of an out of tree
patch I'm carrying adding DT support (which I'd forgotten all about as
I've needed it for so long).  Please disregard this patch.

Re: [PATCH] video: amba-clcd: Select FB_MODE_HELPERS

From: Tomi Valkeinen <hidden>
Date: 2014-08-04 06:48:54

Hi,

On 01/08/14 18:53, Mark Brown wrote:
quoted hunk
From: Mark Brown <redacted>

The AMBA CLCD driver uses fb_videomode_from_videomode() so it needs to
select DB_MODE_HELPERS as well as VIDEOMODE_HELPERS.

Signed-off-by: Mark Brown <redacted>
---
 drivers/video/fbdev/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 37d473f..e222048 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -280,6 +280,7 @@ config FB_ARMCLCD
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
+	select FB_MODE_HELPERS
 	select VIDEOMODE_HELPERS if OF
 	help
 	  This framebuffer device driver is for the ARM PrimeCell PL110
Pawel sent a patch fixing the same issue. I've applied that one.

 Tomi

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help