Re: [PATCH] video: fbdev: intelfb: intelfb_i2c.c: Cleaning up variable that is never used
From: Pavel Machek <hidden>
Date: 2014-07-30 06:50:34
Also in:
lkml
On Sat 2014-07-05 14:24:08, Rickard Strandqvist wrote:
From: Rickard Strandqvist <redacted> Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck
Are you sure this is the right fix? Do we need to read the register in case we don't care about return value?
quoted hunk ↗ jump to hunk
index 3300bd3..4df2f1f 100644--- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c@@ -55,22 +55,20 @@ static void intelfb_gpio_setscl(void *data, int state) { struct intelfb_i2c_chan *chan = data; struct intelfb_info *dinfo = chan->dinfo; - u32 val; OUTREG(chan->reg, (state ? SCL_VAL_OUT : 0) | SCL_DIR | SCL_DIR_MASK | SCL_VAL_MASK); - val = INREG(chan->reg); + INREG(chan->reg); }
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html