Thread (6 messages) 6 messages, 3 authors, 2014-07-09

RE: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

From: Dexuan Cui <decui@microsoft.com>
Date: 2014-07-08 22:18:09
Also in: lkml

-----Original Message-----
From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
Sent: Tuesday, July 8, 2014 17:27 PM
To: Dexuan Cui
Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev-
devel@linuxdriverproject.org; plagnioj@jcrosoft.com;
tomi.valkeinen@ti.com; linux-fbdev@vger.kernel.org; olaf@aepfle.de;
apw@canonical.com; jasowang@redhat.com; Haiyang Zhang
Subject: Re: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by
force on VM panic

Don't use likely/unlikely unless you have benchmark numbers to show that
it makes a speed up.

regards,
dan carpenter
Hi Dan,
Here the variable 'synchronous_fb' is only set to true when the system panics.
So before the system panics, it's always 'unlikely'. :-)

Thanks,
-- Dexuan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help