Thread (3 messages) 3 messages, 2 authors, 2014-07-07

Re: [PATCH] video: backlight: jornada720_lcd.c: Cleaning up variable that is never used

From: Rickard Strandqvist <hidden>
Date: 2014-07-07 20:00:12
Also in: lkml

2014-07-07 12:46 GMT+02:00 Lee Jones [off-list ref]:
quoted
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/backlight/jornada720_lcd.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Solve it the other way around.

Add a check and return the value if an error is returned.
Hi

Ok, I take the opportunity to make a bigger change to clarify the
similarities in function.
Hope you like it, otherwise I can make the minor change instead.

Kind regards
Rickard Strandqvist
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help