Thread (3 messages) 3 messages, 3 authors, 2014-07-08
STALE4393d

[PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter

From: Rickard Strandqvist <hidden>
Date: 2014-07-06 17:26:07
Also in: lkml
Subsystem: framebuffer layer, the rest, xen hypervisor interface · Maintainers: Helge Deller, Linus Torvalds, Juergen Gross, Stefano Stabellini

Remove assignment of function parameter, that has no effect outside the function

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/xen-fbfront.c |    1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 901014b..e1207a1 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
 	red = CNVT_TOHW(red, info->var.red.length);
 	green = CNVT_TOHW(green, info->var.green.length);
 	blue = CNVT_TOHW(blue, info->var.blue.length);
-	transp = CNVT_TOHW(transp, info->var.transp.length);
 #undef CNVT_TOHW
 
 	v = (red << info->var.red.offset) |
-- 
1.7.10.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help