Re: [PATCH] video: fbdev: amifb.c: Cleaning up variable that is never used
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2014-07-05 14:04:26
Also in:
lkml
On Sat, Jul 5, 2014 at 2:13 PM, Rickard Strandqvist [off-list ref] wrote:
From: Rickard Strandqvist <redacted> Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist <redacted>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
quoted hunk ↗ jump to hunk
--- a/drivers/video/fbdev/amifb.c +++ b/drivers/video/fbdev/amifb.c@@ -1124,7 +1124,6 @@ static int ami_decode_var(struct fb_var_screeninfo *var, struct amifb_par *par, { u_short clk_shift, line_shift; u_long maxfetchstop, fstrt, fsize, fconst, xres_n, yres_n; - u_int htotal, vtotal;
These became unused by commit 3161986224a3faa8ccca3e665b7404d81e7ee3cf
Author: Geert Uytterhoeven [off-list ref]
Date: Wed Dec 13 00:35:54 2006 -0800
[PATCH] fbdev: remove references to non-existent fbmon_valid_timings()
Remove references to non-existent fbmon_valid_timings()
Signed-off-by: Geert Uytterhoeven [off-list ref]
Cc: James Simmons [off-list ref]
Signed-off-by: Andrew Morton [off-list ref]
Signed-off-by: Linus Torvalds [off-list ref]
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds