[PATCH] video: fbdev: g364fb.c: Cleaning up variable that is never used

Subsystems: framebuffer layer, the rest

STALE4469d

2 messages, 2 authors, 2014-07-05 · open the first message on its own page

[PATCH] video: fbdev: g364fb.c: Cleaning up variable that is never used

From: Rickard Strandqvist <hidden>
Date: 2014-07-05 12:20:00

From: Rickard Strandqvist <redacted>

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/g364fb.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/g364fb.c b/drivers/video/fbdev/g364fb.c
index 223896c..f84a70e 100644
--- a/drivers/video/fbdev/g364fb.c
+++ b/drivers/video/fbdev/g364fb.c
@@ -194,11 +194,9 @@ static int g364fb_setcolreg(u_int regno, u_int red, u_int green,
  */
 int __init g364fb_init(void)
 {
-	volatile unsigned int *pal_ptr -	    (volatile unsigned int *) CLR_PAL_REG;
 	volatile unsigned int *curs_pal_ptr  	    (volatile unsigned int *) CURS_PAL_REG;
-	int mem, i, j;
+	int mem, i;
 
 	if (fb_get_options("g364fb", NULL))
 		return -ENODEV;
-- 
1.7.10.4

Re: [PATCH] video: fbdev: g364fb.c: Cleaning up variable that is never used

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2014-07-05 17:09:14

On Sat, Jul 5, 2014 at 2:21 PM, Rickard Strandqvist
[off-list ref] wrote:
From: Rickard Strandqvist <redacted>

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help