Thread (2 messages) 2 messages, 2 authors, 2014-07-30

Re: [PATCH -next] backlight: ipaq_micro: Fix sparse non static symbol warning

flat view

From: Bryan Wu <hidden>
Date: 2014-07-29 23:25:43

On Tue, Jul 29, 2014 at 4:20 PM,  [off-list ref] wrote:
From: Wei Yongjun <redacted>

Fixes the following sparse warnings:

drivers/video/backlight/ipaq_micro_bl.c:73:24: warning:
 symbol 'micro_backlight_device_driver' was not declared. Should it be static?
I've merged a similar fix for led-ipaq-micro. So this one looks good to me:

Acked-by: Bryan Wu <redacted>
quoted hunk
Signed-off-by: Wei Yongjun <redacted>
---
 drivers/video/backlight/ipaq_micro_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/ipaq_micro_bl.c b/drivers/video/backlight/ipaq_micro_bl.c
index feab29c..347dc11 100644
--- a/drivers/video/backlight/ipaq_micro_bl.c
+++ b/drivers/video/backlight/ipaq_micro_bl.c
@@ -70,7 +70,7 @@ static int micro_backlight_probe(struct platform_device *pdev)
        return 0;
 }

-struct platform_driver micro_backlight_device_driver = {
+static struct platform_driver micro_backlight_device_driver = {
        .driver = {
                .name    = "ipaq-micro-backlight",
        },
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help