Re: [PATCH -next 25/26] fbdev: Use dma_zalloc_coherent

On Mon, 2014-06-16 at 00:16 +0200, Geert Uytterhoeven wrote:

On Sun, Jun 15, 2014 at 10:37 PM, Joe Perches [off-list ref] wrote:

quoted

diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c

[]

quoted

@@ -1447,18 +1447,15 @@ static int fb_probe(struct platform_device *device)
                da8xx_fb_fix.line_length - 1;

        /* allocate palette buffer */
-       par->v_palette_base = dma_alloc_coherent(NULL,
-                                              PALETTE_SIZE,
-                                              (resource_size_t *)
-                                              &par->p_palette_base,
-                                              GFP_KERNEL | GFP_DMA);
+       par->v_palette_base = dma_zalloc_coherent(NULL, PALETTE_SIZE,
+                                                 (resource_size_t *)&par->p_palette_base,

Suggestion for further cleanup: It seems this cast is no longer needed.

Sure, but after this is applied.