Re: [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp
flat view
From: Tomi Valkeinen <hidden>
Date: 2014-05-09 07:07:19
Also in:
linux-arm-kernel, linux-devicetree, linux-omap
Possibly related (same subject, not in this thread)
- 2014-05-16 · [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp · Tomi Valkeinen <hidden>
- 2014-04-30 · Re: [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp · Tony Lindgren <tony@atomide.com>
- 2014-04-30 · Re: [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp · Joachim Eastwood <hidden>
- 2014-04-29 · [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp · Tony Lindgren <tony@atomide.com>
On 09/05/14 02:36, Tony Lindgren wrote:
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/arch/arm/boot/dts/omap-panel-sharp-ls037v7dw01.dtsi@@ -0,0 +1,82 @@ +/* + * Common file for omap dpi panels with QVGA and reset pins + * + * Note that the board specifc DTS file needs to specify + * at minimum the GPIO enable-gpios for display, and + * gpios for gpio-backlight. + */
This looks very board specific to me... The regulator and the use of mcspi1 depend on the board, so this file can't be used on just any omap board with the same panel. And this can (probably) only be used on boards with a single display. Do those boards have tv-out? So I have nothing against having common files, but shouldn't this be named something more specific? If the boards involved are TI's OMAP3 development boards, maybe this should be something like... omap3-ti-dev-panel-sharp-ls037v7dw01.dtsi. Well, that's a quite long one.
quoted hunk ↗ jump to hunk
+/ { + aliases { + display0 = &lcd0; + }; + + backlight0: backlight { + compatible = "gpio-backlight"; + }; + + /* 3.3V GPIO controlled regulator for LCD_ENVDD */ + lcd_3v3: regulator-lcd-3v3 { + compatible = "regulator-fixed"; + regulator-name = "lcd_3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + startup-delay-us = <70000>; + regulator-always-on;
Why always-on? Tomi
Attachments
- signature.asc [application/pgp-signature] 819 bytes