Re: [PATCH v2 1/3] video: clps711x: Add new Cirrus Logic CLPS711X framebuffer driver
From: Tomi Valkeinen <hidden>
Date: 2014-04-24 07:57:59
Attachments
- signature.asc [application/pgp-signature] 819 bytes
From: Tomi Valkeinen <hidden>
Date: 2014-04-24 07:57:59
Hi, On 12/04/14 09:53, Alexander Shiyan wrote:
This adds support for the framebuffer available in the Cirrus Logic CLPS711X CPUs. FB features: - 1-2-4 bits per pixel. - Programmable panel size to a maximum of 1024x256 at 4 bps. - Relocatible Frame Buffer (SRAM or SDRAM). - Programmable refresh rates. - 16 gray scale values. This new driver supports usage with devicetree and as a general change it removes last user of <mach/hardware.h> for CLPS711X targets, so this subarch will fully prepared to switch to multiplatform. The driver have been tested with custom board equipped Cirrus Logic EP7312 in DT and non-DT mode.
My original comment about this is still unanswered: why a totally new driver? The proper way would be to gradually change the old driver with a patch series. Then it's possible to review the patches and see what is actually changed. Tomi