RE: [PATCH 2/2] video/fsl: Fix the sleep function for FSL DIU module

Jason.Jin@freescale.com wrote:

quoted

[Jason Jin-R64188] It's not hackish, we can provide the pixel clock

register in the DIU node, I did not provide the dts update as this is
only tested on T1040 platform. For other platforms such as p1022 and 8610,
we still can use the pixel clock setting function in the platform.

quoted

The dts node update for T1040 is:
display:display@180000 {
         compatible = "fsl,t1040-diu", "fsl,diu";
-       reg = <0x180000 1000>;
+       reg = <0x180000 1000 0xfc028 4>;
         interrupts = <74 2 0 0>;
};

This is hackish because you're specifying a single register that you want
to preserve in the DTS file, instead of a platform function which is
where it's supposed to be.

[Jason Jin-R64188] The pixel clock register is actually part of the DIU registers although it is not implemented in the diu module. Actually we can use it to set pixel clock in the driver not just saving it in suspend. We can provide the patch for discussion. 

I will think about this some more.  I think you are trying too hard to
avoid a platform file, which is why some of this code is hackish to me.

[Jason Jin-R64188] Thanks. Could you please share you thinking for how to setup the platform file then?