Re: [PATCH v2 4/4] video: mmp: add device tree support

From
Zhou Zhu <hidden>
Date
2014-03-14 10:43:30
Also in
linux-devicetree
Hi, Tomi,

On 03/05/2014 05:33 PM, Tomi Valkeinen wrote:
I would recommend using the same style that is used in the OMAP DSS, imx
drm and exynos patches that are introducing DT support. They use ports
and endpoints as defined in:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/media/video-interfaces.txt

with the addition of a simplified endpoint format, where the 'port' node
is not required.

To give an idea what it could look like, I've modified your example
above. It's just a rough example, you should study and think how it best
fits for mmp.

You could use the same format for the internal connections also, but I
didn't touch that. I think internal connections can as well be
configured separately, in a custom format, because there's no need for
external components to connect to the internal links.

mmp-disp@d420b000 {
     compatible = "marvell,mmp-disp";
     reg = <0xd420b000 0x1fc>;
     interrupts = <0 41 0x4>;

     internal-connections {
         pipe1: pn-path {
         input = "panel-graphic";
         output = &disp_out;
         }
     }

	disp_out: endpoint {
		remote-endpoint = <&panel_in>;
		marvell,rbswap;
		marvell,spi;
	};

     status = "okay";
}

panel-xxx {
	properties;

	panel_in: endpoint {
		remote-endpoint = <&disp_out>;
	};
};

  Tomi
Thank you! I will update patches according to this layout later.


-- 
Thanks,
-Zhou
Thread (1 message) 1 message, 1 author, last reply 2014-03-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help