Re: [PATCH] lib: remove FBCON dependency for fonts

Hi

On Fri, Mar 7, 2014 at 11:39 AM, Geert Uytterhoeven
[off-list ref] wrote:

On Fri, Mar 7, 2014 at 11:14 AM, David Herrmann [off-list ref] wrote:

quoted

Fonts don't depend on CONFIG_FRAMEBUFFER_CONSOLE at all. Remove that.
Besides, CONFIG_FONT_SUPPORT is 'select'ed anyway, so the dependencies
aren't checked by most higher-level options.

CONFIG_FONT_SUPPORT is indeed selected, but the other options are about
which fonts to include by default. No dependencies are bypassed by the select.

Indeed, I missed that, sorry.

Without the "depends on FRAMEBUFFER_CONSOLE", people who don't
have FRAMEBUFFER_CONSOLE set, but have set any of these:

config EARLY_PRINTK_EFI
    select FONT_SUPPORT

config VIDEO_VIVI
    select FONT_SUPPORT
    select FONT_8x16

config SOLO6X10
    select FONT_SUPPORT
    select FONT_8x16

config USB_SISUSBVGA
    select FONT_SUPPORT
    ...
    select FONT_8x16

config SGI_NEWPORT_CONSOLE
    select FONT_SUPPORT

config STI_CONSOLE
    select FONT_SUPPORT

will now get more (unused) fonts in their kernel image.

Why would they get more unused fonts? All those fonts are "default n"
(except for some arch-specific stuff and 8x8 and obviously 8x16). I
don't mind if we drop this, but it makes font-selection impossible if
fbcon is disabled, which is kinda unexpected.

Thanks
David