Re: [PATCH 1/2] backlight: platform_lcd: Remove DT compatibility string
From: Lee Jones <hidden>
Date: 2014-03-31 07:40:42
quoted hunk ↗ jump to hunk
Driver is written for using platform callback functions and it cannot be used without these functions, so having "platform-lcd" in the device tree do nothing. This patch removes DT compatibility string. Signed-off-by: Alexander Shiyan <redacted> --- drivers/video/backlight/platform_lcd.c | 11 ----------- 1 file changed, 11 deletions(-)diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c index c3d2e20..4afc21f 100644 --- a/drivers/video/backlight/platform_lcd.c +++ b/drivers/video/backlight/platform_lcd.c@@ -16,8 +16,6 @@ #include <linux/fb.h> #include <linux/backlight.h> #include <linux/lcd.h> -#include <linux/of.h> -#include <linux/slab.h> #include <video/platform_lcd.h>@@ -137,20 +135,11 @@ static int platform_lcd_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend, platform_lcd_resume); -#ifdef CONFIG_OF -static const struct of_device_id platform_lcd_of_match[] = { - { .compatible = "platform-lcd" }, - {}, -}; -MODULE_DEVICE_TABLE(of, platform_lcd_of_match); -#endif -
Rather than remove DT support, we should look into what these call-back functions to and work to rid those instead. What exactly do these routines provide?
static struct platform_driver platform_lcd_driver = {
.driver = {
.name = "platform-lcd",
.owner = THIS_MODULE,
.pm = &platform_lcd_pm_ops,
- .of_match_table = of_match_ptr(platform_lcd_of_match),
},
.probe = platform_lcd_probe,
};-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog