Re: [PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

On 06/03/14 11:09, Daniel Mack wrote:

On 03/06/2014 03:09 AM, Haojian Zhuang wrote:

quoted

On Thu, Mar 6, 2014 at 12:12 AM, Daniel Mack [off-list ref] wrote:

quoted

Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually
a real bugfix that is needed since the misc code doesn't set
file->private_data for us implicitly anymore.

The rest are just straight-forward cleanups.

Thanks,
Daniel


Daniel Mack (4):
  video: pxa3xx-gcu: rename some symbols
  video: pxa3xx-gcu: pass around struct device *
  video: pxa3xx-gcu: provide an empty .open call
  video: pxa3xx-gcu: switch to devres functions

 drivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++--------------------------
 1 file changed, 81 insertions(+), 110 deletions(-)

quoted

Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>

Thanks Haojian!

Given that this driver doesn't actually have any connection points to
the framebuffer or video subsystem (despite its location) maybe you can
just take these patches through your pxa tree? It's a PXA3xx specific
device, after all. Jean-Christophe, Tomi - any objections?

The driver is also broken since awhile, and the fact that nobody noticed
tells me that our platform is most probably the only real user.

If these do not have any dependencies to non-fbdev patches, and nothing
else has dependencies to these patches, I'd rather take them via fbdev
tree, based on the file location. There shouldn't be any conflicts, but
just in case...

As a side note, I've got a drivers/video/ reorg patch series, possibly
headed for v3.15, which moves the pxa3xx-gcu file to
drivers/video/fbdev/. That's clearly not the right place for it, but I
think it's easier to move it along the other files, and later move it
back to drivers/video/.

 Tomi