[PATCH 1/1] video: exynos: Fix S6E8AX0 LCD driver build error

Subsystems: framebuffer layer, the rest

STALE4625d

8 messages, 2 authors, 2014-02-12 · open the first message on its own page

[PATCH 1/1] video: exynos: Fix S6E8AX0 LCD driver build error

From: Sachin Kamat <hidden>
Date: 2014-02-12 09:55:05

Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver.
Else we get the following errors due to missing symbols:
drivers/built-in.o: In function `s6e8ax0_probe':
:(.text+0x51aec): undefined reference to `lcd_device_register'
:(.text+0x51c44): undefined reference to `lcd_device_unregister'

Signed-off-by: Sachin Kamat <redacted>
---
 drivers/video/exynos/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig
index 976594d578a9..eb6f2b059821 100644
--- a/drivers/video/exynos/Kconfig
+++ b/drivers/video/exynos/Kconfig
@@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI
 
 config EXYNOS_LCD_S6E8AX0
 	bool "S6E8AX0 MIPI AMOLED LCD Driver"
-	depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE)
+	depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE
+	depends on (LCD_CLASS_DEVICE = y)
 	default n
 	help
 	  If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its
-- 
1.7.9.5

Re: [PATCH 1/1] video: exynos: Fix S6E8AX0 LCD driver build error

From: Sachin Kamat <hidden>
Date: 2014-02-12 09:56:08

On 12 February 2014 15:19, Sachin Kamat [off-list ref] wrote:
quoted hunk
Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver.
Else we get the following errors due to missing symbols:
drivers/built-in.o: In function `s6e8ax0_probe':
:(.text+0x51aec): undefined reference to `lcd_device_register'
:(.text+0x51c44): undefined reference to `lcd_device_unregister'

Signed-off-by: Sachin Kamat <redacted>
---
 drivers/video/exynos/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig
index 976594d578a9..eb6f2b059821 100644
--- a/drivers/video/exynos/Kconfig
+++ b/drivers/video/exynos/Kconfig
@@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI

 config EXYNOS_LCD_S6E8AX0
        bool "S6E8AX0 MIPI AMOLED LCD Driver"
-       depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE)
+       depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE
+       depends on (LCD_CLASS_DEVICE = y)
        default n
        help
          If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its
--
1.7.9.5
Sorry, please ignore this.

-- 
With warm regards,
Sachin

Re: [PATCH 1/1] video: exynos: Fix S6E8AX0 LCD driver build error

From: Tomi Valkeinen <hidden>
Date: 2014-02-12 11:26:08

On 12/02/14 11:55, Sachin Kamat wrote:
On 12 February 2014 15:19, Sachin Kamat [off-list ref] wrote:
quoted
Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver.
Else we get the following errors due to missing symbols:
drivers/built-in.o: In function `s6e8ax0_probe':
:(.text+0x51aec): undefined reference to `lcd_device_register'
:(.text+0x51c44): undefined reference to `lcd_device_unregister'

Signed-off-by: Sachin Kamat <redacted>
---
 drivers/video/exynos/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig
index 976594d578a9..eb6f2b059821 100644
--- a/drivers/video/exynos/Kconfig
+++ b/drivers/video/exynos/Kconfig
@@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI

 config EXYNOS_LCD_S6E8AX0
        bool "S6E8AX0 MIPI AMOLED LCD Driver"
-       depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE)
+       depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE
+       depends on (LCD_CLASS_DEVICE = y)
        default n
        help
          If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its
--
1.7.9.5
Sorry, please ignore this.
Hmm? Why is the fix not needed?

 Tomi

Re: [PATCH 1/1] video: exynos: Fix S6E8AX0 LCD driver build error

From: Tomi Valkeinen <hidden>
Date: 2014-02-12 11:42:30

On 12/02/14 13:41, Sachin Kamat wrote:
On 12 February 2014 16:56, Tomi Valkeinen [off-list ref] wrote:
quoted
On 12/02/14 11:55, Sachin Kamat wrote:
quoted
On 12 February 2014 15:19, Sachin Kamat [off-list ref] wrote:
quoted
Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver.
Else we get the following errors due to missing symbols:
drivers/built-in.o: In function `s6e8ax0_probe':
:(.text+0x51aec): undefined reference to `lcd_device_register'
:(.text+0x51c44): undefined reference to `lcd_device_unregister'

Signed-off-by: Sachin Kamat <redacted>
---
 drivers/video/exynos/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig
index 976594d578a9..eb6f2b059821 100644
--- a/drivers/video/exynos/Kconfig
+++ b/drivers/video/exynos/Kconfig
@@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI

 config EXYNOS_LCD_S6E8AX0
        bool "S6E8AX0 MIPI AMOLED LCD Driver"
-       depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE)
+       depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE
+       depends on (LCD_CLASS_DEVICE = y)
        default n
        help
          If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its
--
1.7.9.5
Sorry, please ignore this.
Hmm? Why is the fix not needed?
You said you have already applied this for 3.14-fixes. I accidentally
sent it again.
Ah ok. I thought the patch itself can be ignored (removed from my branch).

 Tomi

Re: [PATCH 1/1] video: exynos: Fix S6E8AX0 LCD driver build error

From: Tomi Valkeinen <hidden>
Date: 2014-02-12 11:51:01

On 12/02/14 13:44, Sachin Kamat wrote:
Btw, is this [1] your current tree as it doesn't look updated since some time?

[1] git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git
Yes, but I haven't pushed any 3.15 or 3.14-fixes content yet. I've been
rather busy in the previous weeks. I'll try to get the current patches
pushed today.

 Tomi

Re: [PATCH 1/1] video: exynos: Fix S6E8AX0 LCD driver build error

From: Sachin Kamat <hidden>
Date: 2014-02-12 11:52:24

On 12 February 2014 17:21, Tomi Valkeinen [off-list ref] wrote:
On 12/02/14 13:44, Sachin Kamat wrote:
quoted
Btw, is this [1] your current tree as it doesn't look updated since some time?

[1] git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git
Yes, but I haven't pushed any 3.15 or 3.14-fixes content yet. I've been
rather busy in the previous weeks. I'll try to get the current patches
pushed today.
Sounds good. Thanks.

-- 
With warm regards,
Sachin

Re: [PATCH 1/1] video: exynos: Fix S6E8AX0 LCD driver build error

From: Sachin Kamat <hidden>
Date: 2014-02-12 11:53:14

On 12 February 2014 16:56, Tomi Valkeinen [off-list ref] wrote:
On 12/02/14 11:55, Sachin Kamat wrote:
quoted
On 12 February 2014 15:19, Sachin Kamat [off-list ref] wrote:
quoted
Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver.
Else we get the following errors due to missing symbols:
drivers/built-in.o: In function `s6e8ax0_probe':
:(.text+0x51aec): undefined reference to `lcd_device_register'
:(.text+0x51c44): undefined reference to `lcd_device_unregister'

Signed-off-by: Sachin Kamat <redacted>
---
 drivers/video/exynos/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig
index 976594d578a9..eb6f2b059821 100644
--- a/drivers/video/exynos/Kconfig
+++ b/drivers/video/exynos/Kconfig
@@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI

 config EXYNOS_LCD_S6E8AX0
        bool "S6E8AX0 MIPI AMOLED LCD Driver"
-       depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE)
+       depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE
+       depends on (LCD_CLASS_DEVICE = y)
        default n
        help
          If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its
--
1.7.9.5
Sorry, please ignore this.
Hmm? Why is the fix not needed?
You said you have already applied this for 3.14-fixes. I accidentally
sent it again.

-- 
With warm regards,
Sachin

Re: [PATCH 1/1] video: exynos: Fix S6E8AX0 LCD driver build error

From: Sachin Kamat <hidden>
Date: 2014-02-12 11:56:57

On 12 February 2014 17:12, Tomi Valkeinen [off-list ref] wrote:
On 12/02/14 13:41, Sachin Kamat wrote:
quoted
On 12 February 2014 16:56, Tomi Valkeinen [off-list ref] wrote:
quoted
On 12/02/14 11:55, Sachin Kamat wrote:
quoted
On 12 February 2014 15:19, Sachin Kamat [off-list ref] wrote:
quoted
Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver.
Else we get the following errors due to missing symbols:
drivers/built-in.o: In function `s6e8ax0_probe':
:(.text+0x51aec): undefined reference to `lcd_device_register'
:(.text+0x51c44): undefined reference to `lcd_device_unregister'

Signed-off-by: Sachin Kamat <redacted>
---
 drivers/video/exynos/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig
index 976594d578a9..eb6f2b059821 100644
--- a/drivers/video/exynos/Kconfig
+++ b/drivers/video/exynos/Kconfig
@@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI

 config EXYNOS_LCD_S6E8AX0
        bool "S6E8AX0 MIPI AMOLED LCD Driver"
-       depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE)
+       depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE
+       depends on (LCD_CLASS_DEVICE = y)
        default n
        help
          If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its
--
1.7.9.5
Sorry, please ignore this.
Hmm? Why is the fix not needed?
You said you have already applied this for 3.14-fixes. I accidentally
sent it again.
Ah ok. I thought the patch itself can be ignored (removed from my branch).
Sorry for causing the confusion and noise.
Btw, is this [1] your current tree as it doesn't look updated since some time?

[1] git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git
-- 
With warm regards,
Sachin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help