Re: [patch 1/2] video: mmp: delete a stray mutex_unlock()
From: Tomi Valkeinen <hidden>
Date: 2014-01-10 11:29:34
Also in:
kernel-janitors
Attachments
- signature.asc [application/pgp-signature] 901 bytes
From: Tomi Valkeinen <hidden>
Date: 2014-01-10 11:29:34
Also in:
kernel-janitors
On 2013-11-14 10:19, Dan Carpenter wrote:
We aren't holding the disp_lock so we shouldn't release it. Signed-off-by: Dan Carpenter <redacted>diff --git a/drivers/video/mmp/core.c b/drivers/video/mmp/core.c index 84de263..c8d4265 100644 --- a/drivers/video/mmp/core.c +++ b/drivers/video/mmp/core.c@@ -173,7 +173,7 @@ struct mmp_path *mmp_register_path(struct mmp_path_info *info) + sizeof(struct mmp_overlay) * info->overlay_num; path = kzalloc(size, GFP_KERNEL); if (!path) - goto failed; + return NULL; /* path set */ mutex_init(&path->access_ok);@@ -219,11 +219,6 @@ struct mmp_path *mmp_register_path(struct mmp_path_info *info) mutex_unlock(&disp_lock); return path; - -failed: - kfree(path); - mutex_unlock(&disp_lock); - return NULL; } EXPORT_SYMBOL_GPL(mmp_register_path);
Queued for 3.14. Tomi