Re: [PATCHv13][ 2/4] video: imxfb: Also add pwmr for the device tree.
From: Sascha Hauer <hidden>
Date: 2013-12-06 08:16:40
On Fri, Dec 06, 2013 at 12:03:54PM +0400, Alexander Shiyan wrote:
quoted
quoted
.../devicetree/bindings/video/fsl,imx-fb.txt | 3 +++ drivers/video/imxfb.c | 2 ++ 2 files changed, 5 insertions(+)diff --git a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt index 46da08d..ac457ae 100644 --- a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt +++ b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt@@ -17,6 +17,9 @@ Required nodes: Optional properties: - fsl,dmacr: DMA Control Register value. This is optional. By default, the register is not modified as recommended by the datasheet. +- fsl,pwmr: LCDC PWM Contrast Control Register value. That property is + optional, but defining it is necessary to get the backlight working. If that + property is ommited, the register is zeroed.Why isn't this implemented as a backlight driver? Static devicetree provided values is very limiting.Let's understand the terminology. This register should be renamed according to the datasheet, i.e. LPCCR. As I pointed out earlier, it is NOT control the backlight, this is a contrast control. Yes, it works as PWM, but nothing do with the backlight subsystem. Yes, we can make a driver for this PWM, but how are we going to control it? I misunderstood something?
I stumbled upon 'get the backlight working' which implied for me that it should be a backlight driver. But you're right and now I remember we talked about this already. I still think this should be something adjustable, not static data. Maybe we could change the wording to something like "This property provides the default value for the contrast control register" since even if we add driver support for controlling the contrast we still want to have a sane default. BTW the contrast could be controlled with a lcd_device (see lcd_device_register) which seems to be very easy to implement. SaschaMaybe we could change the wording to something like "This property provides the default value for the contrast control register" since even if we add driver support for controlling the contrast we still want to have a sane default. BTW the contrast could be controlled with a lcd_device (see lcd_device_register) which seems to be very easy to implement. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |