Re: [PATCH v3] x86: sysfb: remove sysfb when probing real hw
From: Ingo Molnar <mingo@kernel.org>
Date: 2013-12-19 16:36:13
Also in:
lkml, stable
* David Herrmann [off-list ref] wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c@@ -35,6 +35,9 @@ #include <asm/fb.h> +#if IS_ENABLED(CONFIG_X86) +#include <asm/sysfb.h> +#endif
I think this can be written as: #ifdef CONFIG_X86 # include <asm/sysfb.h> #endif also ... the dependency on a large, unrelated option like CONFIG_X86 looks pretty ugly here - is there no other, more specific CONFIG_ option that can be used here - such as CONFIG_FB_SIMPLE or CONFIG_X86_SYSFB?
quoted hunk ↗ jump to hunk
+#if IS_ENABLED(CONFIG_X86) + sysfb_unregister(apert, primary); +#endif
Ditto. Thanks, Ingo