[PATCH 3/4] backlight: lcd: call put_device if device_register fails
From: Levente Kurusa <hidden>
Date: 2013-12-13 19:23:03
Also in:
lkml
Subsystem:
backlight class/subsystem, framebuffer layer, the rest · Maintainers:
Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2014-01-07 · Re: [PATCH 3/4] backlight: lcd: call put_device if device_register fails · Jingoo Han <hidden>
- 2013-12-16 · Re: [PATCH 3/4] backlight: lcd: call put_device if device_register fails · Levente Kurusa <hidden>
- 2013-12-16 · Re: [PATCH 3/4] backlight: lcd: call put_device if device_register fails · Jingoo Han <hidden>
Currently we kfree the container of the device which failed to register. This is wrong as the last reference is not given up with a put_device call. Also, now that we have put_device() callen, we no longer need the kfree as the new_ld->dev.release function will take care of kfreeing the associated memory. Signed-off-by: Levente Kurusa <redacted> --- drivers/video/backlight/lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c
index 93cf15e..7de847d 100644
--- a/drivers/video/backlight/lcd.c
+++ b/drivers/video/backlight/lcd.c@@ -228,7 +228,7 @@ struct lcd_device *lcd_device_register(const char *name, struct device *parent, rc = device_register(&new_ld->dev); if (rc) { - kfree(new_ld); + put_device(&new_ld->dev); return ERR_PTR(rc); }
--
1.8.3.1