Thread (5 messages) 5 messages, 2 authors, 2013-12-20

Re: [PATCH] video/logo: don't look for the logo after system boot

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2013-12-20 15:49:23

On 12/20/2013 04:31 PM, Sebastian Andrzej Siewior wrote:
On 12/20/2013 04:27 PM, Geert Uytterhoeven wrote:
quoted
On Fri, Dec 20, 2013 at 3:24 PM, Sebastian Andrzej Siewior
[off-list ref] wrote:
quoted
If the primary GPU driver has been loaded _after_ system as a module
then this logo memory is no longer valid.
Managed to crash the system by booting a box without a GPU and then
hotpluggin => BOOM.
drivers/video/fbmem.c:fb_prepare_logo() has protection against this:

        if (info->flags & FBINFO_MISC_TILEBLITTING ||
            info->flags & FBINFO_MODULE)
                return 0;
but gpu driver is built-in. I just add PCI device at run-time. The same
thing should happen if you go to sysfs and remove the PCI device and
then do
No I see where you are going with this. My description of the problem
is wrong. The problem is nothing to do with the driver being a module.
If nobody objects this or suggests a different solution then I'm going
to provide a patch with a proper description.

Sebastian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help