Re: [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2013-11-06 11:57:54
Also in:
linux-arm-kernel, linux-sh
Hi Geert, Thank you for the patch. On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set: drivers/video/sh_mobile_meram.c:573: warning: ‘sh_mobile_meram_suspend’ defined but not used drivers/video/sh_mobile_meram.c:597: warning: ‘sh_mobile_meram_resume’ defined but not used Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> and applied to my tree.
quoted hunk ↗ jump to hunk
--- v2: Both functions are used if CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME, as pointed out by Laurent drivers/video/sh_mobile_meram.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/video/sh_mobile_meram.cb/drivers/video/sh_mobile_meram.c index e0f098562a74..a297de5cc859 100644--- a/drivers/video/sh_mobile_meram.c +++ b/drivers/video/sh_mobile_meram.c@@ -569,6 +569,7 @@ EXPORT_SYMBOL_GPL(sh_mobile_meram_cache_update); * Power management */ +#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME) static int sh_mobile_meram_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev);@@ -611,6 +612,7 @@ static int sh_mobile_meram_resume(struct device *dev) meram_write_reg(priv->base, common_regs[i], priv->regs[i]); return 0; } +#endif /* CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME */ static UNIVERSAL_DEV_PM_OPS(sh_mobile_meram_dev_pm_ops, sh_mobile_meram_suspend,
-- Regards, Laurent Pinchart