Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver
From: Donghwa Lee <hidden>
Date: 2013-10-28 06:12:15
Also in:
linux-arm-kernel, linux-media, linux-samsung-soc
On Fri, OCT 25, 2013 06:57, Sylwester Nawrocki wrote:
On 10/24/2013 05:57 PM, Kishon Vijay Abraham I wrote:quoted
On Thursday 24 October 2013 09:12 PM, Sachin Kamat wrote:quoted
On 24 October 2013 20:00, Olof Johansson[off-list ref] wrote:quoted
On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I[off-list ref] wrote:quoted
diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c index 32e5406..00b3a52 100644 --- a/drivers/video/exynos/exynos_mipi_dsi.c +++ b/drivers/video/exynos/exynos_mipi_dsi.c@@ -156,8 +157,7 @@ static int exynos_mipi_dsi_blank_mode(struct mipi_dsim_device *dsim, int power) exynos_mipi_regulator_enable(dsim); /* enable MIPI-DSI PHY. */ - if (dsim->pd->phy_enable) - dsim->pd->phy_enable(pdev, true); + phy_power_on(dsim->phy); clk_enable(dsim->clock);This introduces the below with exynos_defconfig: ../../drivers/video/exynos/exynos_mipi_dsi.c: In function 'exynos_mipi_dsi_blank_mode': ../../drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused variable 'pdev' [-Wunused-variable] struct platform_device *pdev = to_platform_device(dsim->dev);Sorry about missing that, I only noticed this warning recently and didn't get around to submit a patch.quoted
quoted
I have already submitted a patch to fix this [1]Thanks a lot guys for fixing this.quoted
Sorry, missed that :-(This MIPI DSIM driver is affectively a dead code in the mainline now, once Exynos become a dt-only platform. I guess it can be deleted for 3.14, once S5P gets converted to the device tree. The new driver using CDF is basically a complete rewrite. Or device tree support should be added to that driver, but I believe it doesn't make sense without CDF.
MIPI DSIM driver is not a dead code. There is a steady trickle of patches. It's kind of late, but, I will update it as DT based drivers as soon as possible. And Why do you think that DT support of existing MIPI DSIM is something less than great?
-- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html