Re: [PATCH 1/2] framebuffer: Add fb_<level> convenience logging macros
From: Tomi Valkeinen <hidden>
Date: 2013-10-29 10:56:29
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 901 bytes
From: Tomi Valkeinen <hidden>
Date: 2013-10-29 10:56:29
Also in:
lkml
On 20/09/13 04:35, Joe Perches wrote:
Add fb_<level> convenience macros for emitting the "fb%d: ", struct fb_info->node value. Neatens and shortens the code a bit. Signed-off-by: Joe Perches <joe@perches.com> --- include/linux/fb.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)diff --git a/include/linux/fb.h b/include/linux/fb.h index ffac70a..70c4836 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h@@ -792,4 +792,16 @@ extern int fb_find_mode(struct fb_var_screeninfo *var, const struct fb_videomode *default_mode, unsigned int default_bpp); +/* Convenience logging macros */ +#define fb_err(fb_info, fmt, ...) \ + pr_err("fb%d: " fmt, (fb_info)->node, ##__VA_ARGS__) +#define fb_notice(info, fmt, ...) \ + pr_notice("fb%d: " fmt, (fb_info)->node, ##__VA_ARGS__) +#define fb_warn(fb_info, fmt, ...) \ + pr_warn("fb%d: " fmt, (fb_info)->node, ##__VA_ARGS__) +#define fb_info(fb_info, fmt, ...) \ + pr_info("fb%d: " fmt, (fb_info)->node, ##__VA_ARGS__) +#define fb_dbg(fb_info, fmt, ...) \ + pr_debug("fb%d: " fmt, (fb_info)->node, ##__VA_ARGS__) + #endif /* _LINUX_FB_H */
Thanks, queued this and the next one for 3.13. Tomi