[PATCH 1/9] backlight: atmel-pwm-bl: fix reported brightness
flat view
STALE4745d
SUPERSEDED: 1 (0M)
From: Johan Hovold <hidden>
Date: 2013-10-23 09:56:10
Also in:
lkml, stable
Subsystem:
backlight class/subsystem, framebuffer layer, the rest · Maintainers:
Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller, Linus Torvalds
Status: Superseded by v3 (posted 2013-10-31). [go to v3]
Revision resend (4 revisions archived); 1 review trailer.
Revisions (4)
- v1
- resend current
- v2 [diff against previous]
- v3 [diff against previous]
The driver supports 16-bit brightness values, but the value returned from get_brightness was truncated to eight bits. Cc: <redacted> Acked-by: Jingoo Han <redacted> Signed-off-by: Johan Hovold <redacted> --- drivers/video/backlight/atmel-pwm-bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c
index 66885fb..8aac273 100644
--- a/drivers/video/backlight/atmel-pwm-bl.c
+++ b/drivers/video/backlight/atmel-pwm-bl.c@@ -70,7 +70,7 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd) static int atmel_pwm_bl_get_intensity(struct backlight_device *bd) { struct atmel_pwm_bl *pwmbl = bl_get_data(bd); - u8 intensity; + u32 intensity; if (pwmbl->pdata->pwm_active_low) { intensity = pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY) -
@@ -80,7 +80,7 @@ static int atmel_pwm_bl_get_intensity(struct backlight_device *bd) pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY); } - return intensity; + return (u16)intensity; } static int atmel_pwm_bl_init_pwm(struct atmel_pwm_bl *pwmbl)
--
1.8.4