Re: [RFC 00/22] OMAPDSS: DT support

On 04/09/13 10:29, Stefan Roese wrote:

On 28.08.2013 13:40, Tero Kristo wrote:

quoted

On 08/28/2013 01:14 PM, Tomi Valkeinen wrote:

quoted

On 28/08/13 12:48, Tero Kristo wrote:

quoted

On 08/28/2013 12:22 PM, Tomi Valkeinen wrote:

quoted

Hi,

I'm seeing odd clock behavior with Beagle, booting with DT. I'm using
v3.11-rc7 + DSS DT patches.

I guess you are not using the clock DT patches? Just making sure I
didn't break anything.

No, plain rc7 with my DSS DT patches.

quoted

quoted

So, for some reason, the first clk_set_rate goes wrong. Any ideas?

Hmm, strange. I am not seeing similar behavior, but I am calling
clk_set_rate in different location.... also I am using clock DT patches
(don't try the current version though, as I am reworking them.)

[    0.000000] dpll4_ck: 432000000
[    0.000000] dpll4_m4_ck: 72000000
[    0.000000] dpll4_m4x2_ck: 144000000
[    0.000000] dss1_alwon_fck_3430es2: 144000000
[    0.000000] dpll4_ck: 432000000
[    0.000000] dpll4_m4_ck: 86400000
[    0.000000] dpll4_m4x2_ck: 172800000
[    0.000000] dss1_alwon_fck_3430es2: 172800000

Do you see the error only when setting to some specific rate (86400000)
or it doesn't matter?

I also tried setting to 72000000, with the same result.

Do you know if I can somehow easily get debug prints from the clock
framework, that could lighten up the issue?

There isn't any good config option for that, I would suggest add prints
to the clk_set_rate and then for the clocks you are interested in, print
results for the recalc_rate / set_rate ops also.

Tomi, did you make any progress on this issue? If not I'll try to dig
into it later this week.

No, I haven't had time to debug this. And as this seems to show only
with DT, it's not a very high priority for me. DSS DT for OMAP4 is the
main priority, as the board files have already been removed for OMAP4
boards.

BTW: Whats the current plan for your OMAPDSS DT patchset? Is it queued
for v3.12 (this merge windows)? And do you have a git tree to pull the
latest version from?

The git tree was mentioned in the intro mail.

No, DSS DT won't be in for 3.12. My current feeling is that it will
still take multiple kernel versions until it can be merged.

 Tomi