Re: [PATCH 3/3] video: xilinxfb: Simplify error path
From: Tomi Valkeinen <hidden>
Date: 2013-09-16 09:52:05
Also in:
lkml
On 12/09/13 08:54, Michal Simek wrote:
quoted hunk ↗ jump to hunk
@@ -394,16 +382,12 @@ static int xilinxfb_release(struct device *dev) /* Turn off the display */ xilinx_fb_out32(drvdata, REG_CTRL, 0); - /* Release the resources, as allocated based on interface */ - if (drvdata->flags & BUS_ACCESS_FLAG) - devm_iounmap(dev, drvdata->regs); #ifdef CONFIG_PPC_DCR - else + /* Release the resources, as allocated based on interface */ + if (!(drvdata->flags & BUS_ACCESS_FLAG)) dcr_unmap(drvdata->dcr_host, drvdata->dcr_len); #endif
I might be mistaken, and it's not strictly part of this series, but shouldn't dcr_unmap be called somewhere else also, if the probe fails? Tomi
Attachments
- signature.asc [application/pgp-signature] 901 bytes