Re: [PATCH] video/ps3fb: Fix section mismatch warning

On 16/09/13 12:28, Geert Uytterhoeven wrote:

On Mon, Sep 16, 2013 at 11:20 AM, Tomi Valkeinen [off-list ref] wrote:

quoted

On 21/05/13 16:01, Geoff Levand wrote:

quoted

Remove the __initdata attribute from the ps3fb_fix variable.  This is in
follow up to the removal of the __devinit attribute on the ps3fb_probe()
routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers:
video: remove __dev* attributes).

Fixes build warnings like these:

  WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix
  The function .ps3fb_probe() references the variable __initdata ps3fb_fix.
  This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.

Signed-off-by: Geoff Levand <geoff@infradead.org>

Thanks, applied for 3.13.

Too late. It already got in last week through Cell and PS3 supporter BenH ;-)

Ok, thanks for informing. Maybe I'll be faster next time, shouldn't be
difficult to achieve ;).

 Tomi