[PATCH 2/2] backlight: tosa: Remove redundant spi_set_drvdata

Subsystems: backlight class/subsystem, framebuffer layer, the rest

STALE4734d

2 messages, 2 authors, 2013-09-24 · open the first message on its own page

[PATCH 2/2] backlight: tosa: Remove redundant spi_set_drvdata

From: Sachin Kamat <hidden>
Date: 2013-09-20 06:50:53

Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <redacted>
---
 drivers/video/backlight/tosa_lcd.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/video/backlight/tosa_lcd.c b/drivers/video/backlight/tosa_lcd.c
index bf08157..be5d636 100644
--- a/drivers/video/backlight/tosa_lcd.c
+++ b/drivers/video/backlight/tosa_lcd.c
@@ -198,7 +198,7 @@ static int tosa_lcd_probe(struct spi_device *spi)
 	ret = devm_gpio_request_one(&spi->dev, TOSA_GPIO_TG_ON,
 				GPIOF_OUT_INIT_LOW, "tg #pwr");
 	if (ret < 0)
-		goto err_gpio_tg;
+		return ret;
 
 	mdelay(60);
 
@@ -219,8 +219,6 @@ static int tosa_lcd_probe(struct spi_device *spi)
 
 err_register:
 	tosa_lcd_tg_off(data);
-err_gpio_tg:
-	spi_set_drvdata(spi, NULL);
 	return ret;
 }
 
@@ -235,8 +233,6 @@ static int tosa_lcd_remove(struct spi_device *spi)
 
 	tosa_lcd_tg_off(data);
 
-	spi_set_drvdata(spi, NULL);
-
 	return 0;
 }
 
-- 
1.7.9.5

Re: [PATCH 2/2] backlight: tosa: Remove redundant spi_set_drvdata

From: Jingoo Han <hidden>
Date: 2013-09-24 05:41:55

On Friday, September 20, 2013 3:39 PM, Sachin Kamat wrote:
Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <redacted>
Acked-by: Jingoo Han <redacted>

It looks good.
Thank you for sending the patch.

Best regards,
Jingoo Han
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help