[PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type

Subsystems: backlight class/subsystem, framebuffer layer, the rest

STALE4696d

3 messages, 2 authors, 2013-09-27 · open the first message on its own page

[PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type

From: Sachin Kamat <hidden>
Date: 2013-09-26 11:59:44

'lm3630a_read' returns a negative error code upon failure. This
will never get detected by unsigned 'rval'. Make it signed.

Signed-off-by: Sachin Kamat <redacted>
Cc: Daniel Jeong <redacted>
---
 drivers/video/backlight/lm3630a_bl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index c63f918..65392f9 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
 /* interrupt handling */
 static void lm3630a_delayed_func(struct work_struct *work)
 {
-	unsigned int rval;
+	int rval;
 	struct lm3630a_chip *pchip;
 
 	pchip = container_of(work, struct lm3630a_chip, work.work);
-- 
1.7.9.5

Re: [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type

From: Jingoo Han <hidden>
Date: 2013-09-27 00:14:24

On Thursday, September 26, 2013 9:00 PM, Sachin Kamat wrote:
'lm3630a_read' returns a negative error code upon failure. This
will never get detected by unsigned 'rval'. Make it signed.
Hi Sachin Kamat,

The same patch was already sent by Dan Carpenter two days ago.
Also, it was merged to mm tree by Andrew Morton with my Acked-by.
Thank you for caring. :-)

Best regards,
Jingoo Han
quoted hunk
Signed-off-by: Sachin Kamat <redacted>
Cc: Daniel Jeong <redacted>
---
 drivers/video/backlight/lm3630a_bl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index c63f918..65392f9 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
 /* interrupt handling */
 static void lm3630a_delayed_func(struct work_struct *work)
 {
-	unsigned int rval;
+	int rval;
 	struct lm3630a_chip *pchip;

 	pchip = container_of(work, struct lm3630a_chip, work.work);
--
1.7.9.5

Re: [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type

From: Sachin Kamat <hidden>
Date: 2013-09-27 03:20:07

On 27 September 2013 05:44, Jingoo Han [off-list ref] wrote:
On Thursday, September 26, 2013 9:00 PM, Sachin Kamat wrote:

The same patch was already sent by Dan Carpenter two days ago.
Also, it was merged to mm tree by Andrew Morton with my Acked-by.
Thank you for caring. :-)
Sounds great, Thanks for letting me know.

-- 
With warm regards,
Sachin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help