[PATCH] video: remove unused variable dev

Subsystems: framebuffer layer, the rest

STALE4755d

3 messages, 2 authors, 2013-07-29 · open the first message on its own page

[PATCH] video: remove unused variable dev

From: Kefeng Wang <hidden>
Date: 2013-07-27 10:06:16

Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
variable dev is unused, so remove it.

Signed-off-by: Kefeng Wang <redacted>
---
 drivers/video/vga16fb.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
 
 static void vga16fb_destroy(struct fb_info *info)
 {
-	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
 	iounmap(info->screen_base);
 	fb_dealloc_cmap(&info->cmap);
 	/* XXX unshare VGA regions */
-- 
1.8.2.2

Re: [PATCH] video: remove unused variable dev

From: Jingoo Han <hidden>
Date: 2013-07-29 00:52:40

On Saturday, July 27, 2013 7:05 PM, Kefeng Wang wrote:
Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
variable dev is unused, so remove it.

Signed-off-by: Kefeng Wang <redacted>
---
 drivers/video/vga16fb.c | 1 -
 1 file changed, 1 deletion(-)
CC'ed Luis Henriques.


Hi Kefeng Wang,

The same patch was submitted by Luis Henriques 2 weeks ago.
Also, the patch was already applied by Tomi Valkeinen.

Best regards,
Jingoo Han
quoted hunk
diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image

 static void vga16fb_destroy(struct fb_info *info)
 {
-	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
 	iounmap(info->screen_base);
 	fb_dealloc_cmap(&info->cmap);
 	/* XXX unshare VGA regions */
--
1.8.2.2

Re: [PATCH] video: remove unused variable dev

From: Kefeng Wang <hidden>
Date: 2013-07-29 01:28:37

On 07/29 8:52, Jingoo Han wrote:
On Saturday, July 27, 2013 7:05 PM, Kefeng Wang wrote:
quoted
Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
variable dev is unused, so remove it.

Signed-off-by: Kefeng Wang <redacted>
---
 drivers/video/vga16fb.c | 1 -
 1 file changed, 1 deletion(-)
CC'ed Luis Henriques.


Hi Kefeng Wang,

The same patch was submitted by Luis Henriques 2 weeks ago.
Also, the patch was already applied by Tomi Valkeinen.

Best regards,
Jingoo Han
Thanks for your reply, I got it, so ignore it.
quoted
diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image

 static void vga16fb_destroy(struct fb_info *info)
 {
-	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
 	iounmap(info->screen_base);
 	fb_dealloc_cmap(&info->cmap);
 	/* XXX unshare VGA regions */
--
1.8.2.2


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help