Re: [PATCH v3] video: xilinxfb: Fix compilation warning
From: Tomi Valkeinen <hidden>
Date: 2013-07-26 07:33:22
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 901 bytes
From: Tomi Valkeinen <hidden>
Date: 2013-07-26 07:33:22
Also in:
lkml
On 25/07/13 16:45, Michal Simek wrote:
regs_phys is phys_addr_t (u32 or u64). Lets use %pa printk format specifier. Fixes compilation warning introduced by: video: xilinxfb: Use drvdata->regs_phys instead of physaddr (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81) Signed-off-by: Michal Simek <redacted> --- Changes in v3: - Fix commit message reported by Geert Changes in v2: - Use %pa instead of casting ppc44x_defconfig Fixes regressions in v3.11-rc2 --- drivers/video/xilinxfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c index f3d4a69..6629b29 100644 --- a/drivers/video/xilinxfb.c +++ b/drivers/video/xilinxfb.c@@ -341,8 +341,8 @@ static int xilinxfb_assign(struct platform_device *pdev, if (drvdata->flags & BUS_ACCESS_FLAG) { /* Put a banner in the log (for DEBUG) */ - dev_dbg(dev, "regs: phys=%x, virt=%p\n", drvdata->regs_phys, - drvdata->regs); + dev_dbg(dev, "regs: phys=%pa, virt=%p\n", + &drvdata->regs_phys, drvdata->regs); } /* Put a banner in the log (for DEBUG) */ dev_dbg(dev, "fb: phys=%llx, virt=%p, size=%x\n", --1.8.2.3
Thanks, I've applied this into my 3.12/fbdev branch. Tomi