[PATCH] backlight: lp855x: set zero brightness at FBBLANK

Subsystems: backlight class/subsystem, framebuffer layer, the rest

STALE4767d

4 messages, 4 authors, 2013-07-26 · open the first message on its own page

[PATCH] backlight: lp855x: set zero brightness at FBBLANK

From: Oskar Andero <hidden>
Date: 2013-07-02 12:16:00

From: Shingo Nakao <redacted>

When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.

Signed-off-by: Shingo Nakao <redacted>
Cc: Milo Kim <redacted>
Cc: Richard Purdie <redacted>
Signed-off-by: Oskar Andero <redacted>
---
 drivers/video/backlight/lp855x_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c

@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
 {
 	struct lp855x *lp = bl_get_data(bl);
 
-	if (bl->props.state & BL_CORE_SUSPENDED)
+	if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
 		bl->props.brightness = 0;
 
 	if (lp->mode = PWM_BASED) {

-- 
1.8.1.5

Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK

From: Kim, Milo <hidden>
Date: 2013-07-02 23:25:03

From: Shingo Nakao <redacted>

When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.

Signed-off-by: Shingo Nakao <redacted>
Cc: Milo Kim <redacted>
Cc: Richard Purdie <redacted>
Signed-off-by: Oskar Andero <redacted>

Acked-by: Milo Kim <redacted>

quoted hunk

---
 drivers/video/backlight/lp855x_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c

@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
 {
        struct lp855x *lp = bl_get_data(bl);

-       if (bl->props.state & BL_CORE_SUSPENDED)
+       if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
                bl->props.brightness = 0;

        if (lp->mode = PWM_BASED) {
--

1.8.1.5

Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK

From: Jingoo Han <hidden>
Date: 2013-07-03 01:52:21

On Tuesday, July 02, 2013 9:16 PM, Oskar Andero wrote:

From: Shingo Nakao <redacted>

When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.

Signed-off-by: Shingo Nakao <redacted>
Cc: Milo Kim <redacted>
Cc: Richard Purdie <redacted>
Signed-off-by: Oskar Andero <redacted>

Acked-by: Jingoo Han <redacted>

Best regards,
Jingoo Han

quoted hunk

---
 drivers/video/backlight/lp855x_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c

@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
 {
 	struct lp855x *lp = bl_get_data(bl);

-	if (bl->props.state & BL_CORE_SUSPENDED)
+	if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
 		bl->props.brightness = 0;

 	if (lp->mode = PWM_BASED) {
--

1.8.1.5

Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK

From: Tomi Valkeinen <hidden>
Date: 2013-07-26 08:46:00

On 02/07/13 15:15, Oskar Andero wrote:

quoted hunk

From: Shingo Nakao <redacted>

When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.

Signed-off-by: Shingo Nakao <redacted>
Cc: Milo Kim <redacted>
Cc: Richard Purdie <redacted>
Signed-off-by: Oskar Andero <redacted>
---
 drivers/video/backlight/lp855x_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c

@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
 {
 	struct lp855x *lp = bl_get_data(bl);
 
-	if (bl->props.state & BL_CORE_SUSPENDED)
+	if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
 		bl->props.brightness = 0;
 
 	if (lp->mode == PWM_BASED) {

Thanks, I've applied this into my 3.12/fbdev branch.

 Tomi

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help