backlight: lp855x: set zero brightness at FBBLANK

Started by Oskar Andero on Jul 2, 2013 · 4 messages from 4 authors · Last reply Jul 26, 2013

Subsystems (3)

Maintainers (5)

Show 1 more
STALE4858d

open the first message on its own page

Message details and related content
From: Shingo Nakao <redacted>

When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.

Signed-off-by: Shingo Nakao <redacted>
Cc: Milo Kim <redacted>
Cc: Richard Purdie <redacted>
Signed-off-by: Oskar Andero <redacted>
---
 drivers/video/backlight/lp855x_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
 {
 	struct lp855x *lp = bl_get_data(bl);
 
-	if (bl->props.state & BL_CORE_SUSPENDED)
+	if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
 		bl->props.brightness = 0;
 
 	if (lp->mode = PWM_BASED) {
-- 
1.8.1.5
Message details and related content
From: Shingo Nakao <redacted>

When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.

Signed-off-by: Shingo Nakao <redacted>
Cc: Milo Kim <redacted>
Cc: Richard Purdie <redacted>
Signed-off-by: Oskar Andero <redacted>
Acked-by: Milo Kim <redacted>
quoted hunk
---
 drivers/video/backlight/lp855x_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
 {
        struct lp855x *lp = bl_get_data(bl);

-       if (bl->props.state & BL_CORE_SUSPENDED)
+       if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
                bl->props.brightness = 0;

        if (lp->mode = PWM_BASED) {
--
1.8.1.5
Message details and related content
On Tuesday, July 02, 2013 9:16 PM, Oskar Andero wrote:
From: Shingo Nakao <redacted>

When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.

Signed-off-by: Shingo Nakao <redacted>
Cc: Milo Kim <redacted>
Cc: Richard Purdie <redacted>
Signed-off-by: Oskar Andero <redacted>
Acked-by: Jingoo Han <redacted>

Best regards,
Jingoo Han
quoted hunk
---
 drivers/video/backlight/lp855x_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
 {
 	struct lp855x *lp = bl_get_data(bl);

-	if (bl->props.state & BL_CORE_SUSPENDED)
+	if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
 		bl->props.brightness = 0;

 	if (lp->mode = PWM_BASED) {
--
1.8.1.5
Message details and related content
On 02/07/13 15:15, Oskar Andero wrote:
quoted hunk
From: Shingo Nakao <redacted>

When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.

Signed-off-by: Shingo Nakao <redacted>
Cc: Milo Kim <redacted>
Cc: Richard Purdie <redacted>
Signed-off-by: Oskar Andero <redacted>
---
 drivers/video/backlight/lp855x_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
 {
 	struct lp855x *lp = bl_get_data(bl);
 
-	if (bl->props.state & BL_CORE_SUSPENDED)
+	if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
 		bl->props.brightness = 0;
 
 	if (lp->mode == PWM_BASED) {
Thanks, I've applied this into my 3.12/fbdev branch.

 Tomi

Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help